Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab response type (silentAuth) from bot is not supported #4312

Closed
moira2k opened this issue Aug 22, 2022 · 7 comments
Closed

Tab response type (silentAuth) from bot is not supported #4312

moira2k opened this issue Aug 22, 2022 · 7 comments
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.

Comments

@moira2k
Copy link

moira2k commented Aug 22, 2022

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Versions

What package version of the SDK are you using: v4.17.0
What nodejs version are you using: v16.15.1
What browser version are you using: Version 104.0.1293.54 (Official build) (64-bit)
What os are you using: windows 10

Describe the bug

I want to enable SSO for Adaptive Cards Tab following the SSO pattern for message extensions.

And the type of interface TabResponsePayload includes "silentAuth". refer to the url: https://github.com/microsoft/botbuilder-js/blob/main/libraries/botframework-schema/src/teams/index.ts#L1352

type?: "continue" | "auth" | "silentAuth"

In handleTeamsTabFetch, I return the tabResponse:

{
            tab: {
                type: "silentAuth",
                suggestedActions: {
                    actions: [
                        {
                            type: "openUrl",
                            value: signInLink,
                            title: "Sign in to this app"
                        }
                    ]
                }
            }
}

However, when I was debugging in Microsoft Teams, the error occurred(go to the Network Tab of DevTools): {"errorCode":1008,"message":"Error when processing invoke response: Tab response type (silentAuth) from bot is not supported"}

Screenshots

image

@moira2k moira2k added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Aug 22, 2022
@breakingram breakingram self-assigned this Aug 22, 2022
@breakingram breakingram added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Aug 22, 2022
@breakingram
Copy link
Contributor

Hi @moira2k, I'm investigating.

@johnataylor johnataylor added the customer-reported Issue is created by anyone that is not a collaborator in the repository. label Aug 23, 2022
@breakingram
Copy link
Contributor

Hi @moira2k,

Looks like this is related to #4296
This will probably be fixed in next release. PR has been merged. #4305.

In the meantime, @moira2k instead of SDK v4.17.0, could you please try botbuilder 4.18 from the JS daily build feed.

Thanks.

@breakingram breakingram added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label Aug 23, 2022
@moira2k
Copy link
Author

moira2k commented Sep 2, 2022

I try botbuilder 4.18 but the same error occurs again.

@anishprasad01
Copy link
Contributor

Hi @moira2k,

It looks like the fix in question is part of the botframework-schema package. If you solely updated the botbuilder package, you would not have pulled this fix. Could you please try updating the botframework-schema package in your solution to the latest botframework-schema daily and try again?

@moira2k
Copy link
Author

moira2k commented Sep 9, 2022

I think this is because Teams doesn't support it yet, not botbuilder. There is no error in the code check and no error is reported in the console run by npm. The error is happening on the web side.

@breakingram
Copy link
Contributor

Looks like this is a feature request for Teams.

@breakingram
Copy link
Contributor

@moira2k,

There is no SSO support for Adaptive Card Tabs. At the time when it was built message extensions did not support SSO.
Could you please raise a feature request here: Microsoft Teams Community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.
Projects
None yet
Development

No branches or pull requests

4 participants