Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterizedBotFrameworkAuthentication should use connectorClientOptions #4420

Closed
k44 opened this issue Jan 27, 2023 · 0 comments · Fixed by #4421
Closed

ParameterizedBotFrameworkAuthentication should use connectorClientOptions #4420

k44 opened this issue Jan 27, 2023 · 0 comments · Fixed by #4421
Assignees
@johnataylor
Labels
bug Indicates an unexpected problem or an unintended behavior. feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@k44
Copy link
Contributor

k44 commented Jan 27, 2023

Versions

Latest

Describe the bug

ParameterizedBotFrameworkAuthentication should use connectorClientOptions to create ConnectorFactory.

Expected behavior

ParameterizedBotFrameworkAuthentication uses connectorClientOptions to create ConnectorFactory.
@k44 k44 added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jan 27, 2023
k44 added a commit to k44/botbuilder-js that referenced this issue Jan 27, 2023
@k44
fix: use connectorClientOptions to create ConnectorFactory (microsoft…
cc4c733 
…#4420)
@k44 k44 mentioned this issue Jan 27, 2023
Merged
@anishprasad01 anishprasad01 added the feature-request A request for new functionality or an enhancement to an existing one. label Jan 27, 2023
k44 added a commit to k44/botbuilder-js that referenced this issue Jan 29, 2023
@k44
fix: use connectorClientOptions to create ConnectorFactory (microsoft…
fc8d1ab 
…#4420)
tracyboehrer pushed a commit that referenced this issue Oct 19, 2023
@k44
fix: use connectorClientOptions to create ConnectorFactory (#4420) (#…
c288fc7 
…4421)
tracyboehrer pushed a commit that referenced this issue Nov 3, 2023
@k44
fix: use connectorClientOptions to create ConnectorFactory (#4420) (#…
2851f8b 
…4421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnataylor johnataylor

Labels
bug Indicates an unexpected problem or an unintended behavior. feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use connectorClientOptions to create ConnectorFactory (#4420) k44/botbuilder-js
3 participants
@k44 @johnataylor @anishprasad01