[botframework-streaming] Test cases with .to.not.throw
are inconclusive
#4456
Labels
bug
Indicates an unexpected problem or an unintended behavior.
needs-triage
The issue has just been created and it has not been reviewed by the team.
Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Versions
What package version of the SDK are you using.
main
What nodejs version are you using
18
What browser version are you using
Unrelated
What os are you using
Unrelated
Describe the bug
Many of the tests write like this:
However, when calling
expect(fn).to.not.throw
. This does not callfn()
to evaluate the result. It simply do nothing.It should be
expect(fn).to.not.throw()
.To Reproduce
In Mocha, try this test.
Expected behavior
This test should fail.
However, because
.to.not.throw
is not called, the test is not callingfn()
and it is not thrown.After changing to
.to.not.throw()
, the test will fail and this is correct behavior.Screenshots
Additional context
There are 62 tests that are inconclusive because of this issue.
The text was updated successfully, but these errors were encountered: