Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#5820] Outgoing Activity Locale being Overwritten #4481

Closed
ceciliaavila opened this issue Jun 2, 2023 · 0 comments · Fixed by #4489
Closed

port: [#5820] Outgoing Activity Locale being Overwritten #4481

ceciliaavila opened this issue Jun 2, 2023 · 0 comments · Fixed by #4489
Assignees
@ceciliaavila
Labels
bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms.

Comments

@ceciliaavila
Copy link
Collaborator

The changes in [#5820] Outgoing Activity Locale being Overwritten may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5820

Description

This PR updates the Activity's ApplyConversationReference method to prioritize the activity's locale over the reference locale.

Specific Changes

  • Updated ApplyConversationReference method in ActivityEx class to use the activity's locale first. If it's null, use the reference's locale.
  • Updated unit tests to assert the right locale values.

Testing

These images show the overridden locale property (before) and how it's kept after the changes.

BEFORE:
image

AFTER:
image
@ceciliaavila ceciliaavila added bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms. labels Jun 2, 2023
@ceciliaavila ceciliaavila self-assigned this Jun 2, 2023
@ceciliaavila ceciliaavila linked a pull request Jun 14, 2023 that will close this issue
port: [#4481] Outgoing Activity Locale being Overwritten #4489
Merged
@ceciliaavila ceciliaavila mentioned this issue Jun 14, 2023
Merged
tracyboehrer pushed a commit that referenced this issue Jul 14, 2023
@ceciliaavila @JhontSouth
port: [#4481] Outgoing Activity Locale being Overwritten (#4489)
6cae128 
* fix activity locale overwriting

* add overwriting test

* fix package json format

* remove only tag and format code

---------

Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4481] Outgoing Activity Locale being Overwritten microsoft/botbuilder-js
1 participant
@ceciliaavila