Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6588] UserId not being passed to AzureDiagnostics #4482

Closed
ceciliaavila opened this issue Jun 2, 2023 · 0 comments · Fixed by #4493
Closed

port: [#6588] UserId not being passed to AzureDiagnostics #4482

ceciliaavila opened this issue Jun 2, 2023 · 0 comments · Fixed by #4493
Assignees
@ceciliaavila
Labels
bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms.

Comments

@ceciliaavila
Copy link
Collaborator

The changes in [#6588] UserId not being passed to AzureDiagnostics may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes https://github.com/microsoft/botframework-sdk/issues/6588

Description

This PR fixes an issue where the userId property was empty when displaying the AzureDiagnostics table in the Log Analytics workspace resource.

Specific Changes

  • Added userId property to the query-knowledgebases request in the LanguageServiceUtils file.
  • Added unit test in the LanguageServiceTests file to validate when the userId property is empty.
  • Updated failing tests in the LanguageServiceTests file.

Testing

The following images show the unit tests passing and the AzureDiagnostics logs from the Language service resource.
image
image
@ceciliaavila ceciliaavila added bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms. labels Jun 2, 2023
@ceciliaavila ceciliaavila self-assigned this Jun 2, 2023
@ceciliaavila ceciliaavila mentioned this issue Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
bug Indicates an unexpected problem or an unintended behavior. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4482][#6588] UserId not being passed to AzureDiagnostics microsoft/botbuilder-js
1 participant
@ceciliaavila