Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6588] UserId not being passed to AzureDiagnostics #6623

Merged
merged 2 commits into from
May 11, 2023

Conversation

sw-joelmut
Copy link
Collaborator

Fixes microsoft/botframework-sdk#6588

Description

This PR fixes an issue where the userId property was empty when displaying the AzureDiagnostics table in the Log Analytics workspace resource.

Specific Changes

  • Added userId property to the query-knowledgebases request in the LanguageServiceUtils file.
  • Added unit test in the LanguageServiceTests file to validate when the userId property is empty.
  • Updated failing tests in the LanguageServiceTests file.

Testing

The following images show the unit tests passing and the AzureDiagnostics logs from the Language service resource.
image
image

@sw-joelmut sw-joelmut added the Automation: Parity with js The PR needs to be ported to JS label Apr 27, 2023
@sw-joelmut sw-joelmut requested a review from a team as a code owner April 27, 2023 13:13
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 349477

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 79.097%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.AI.QnA/Utils/LanguageServiceUtils.cs 3 83.12%
Totals Coverage Status
Change from base Build 349053: 0.004%
Covered Lines: 25829
Relevant Lines: 32655

💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserId not propagating from DirectLineJS to Azure Log Analytics
4 participants