Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6677][Teams] Add support for meeting participants added/removed events #4530

Closed
ceciliaavila opened this issue Sep 4, 2023 · 0 comments · Fixed by #4538
Closed

port: [#6677][Teams] Add support for meeting participants added/removed events #4530

ceciliaavila opened this issue Sep 4, 2023 · 0 comments · Fixed by #4538
Assignees
@ceciliaavila
Labels
feature-request A request for new functionality or an enhancement to an existing one. parity The issue describes a gap in parity between two or more platforms.

Comments

@ceciliaavila
Copy link
Collaborator

The changes in [#6677][Teams] Add support for meeting participants added/removed events may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

#minor

Description

This PR is based on #5809. It adds support to TeamsActivityHandler for meeting participant join/leave events.

Specific Changes

  • Added support for 2 new activity types - application/vnd.microsoft.meetingParticipantJoin and application/vnd.microsoft.meetingParticipantLeave.
  • Added functions to register handlers for when teams meeting participants are joined/left.
  • Added unit tests.

Testing

These images show the new unit tests passing and the implementation tested with a sample.
image
image
image
@ceciliaavila ceciliaavila added feature-request A request for new functionality or an enhancement to an existing one. parity The issue describes a gap in parity between two or more platforms. labels Sep 4, 2023
@ceciliaavila ceciliaavila self-assigned this Sep 4, 2023
@ceciliaavila ceciliaavila mentioned this issue Sep 21, 2023
Merged
tracyboehrer pushed a commit that referenced this issue Oct 3, 2023
@ceciliaavila @JhontSouth
port: [#4530] Add support for meeting participants added/removed even…
10b9fe0 
…ts (#4538)

* add meeting participants events

* add unit tests

* fix api signatures

---------

Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
feature-request A request for new functionality or an enhancement to an existing one. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4530] Add support for meeting participants added/removed events microsoft/botbuilder-js
1 participant
@ceciliaavila