-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgate zod package #4545
Comments
+1 |
1 similar comment
+1 |
🔐 |
➕ |
+1 |
1 similar comment
👍 |
+1 we are use the botkit to generate our application ,in recently trivy scan , we found the issue of Zod. actually zod already fix this, but bot builder did not fix this. please upgrade of Zod to 3.xx |
+1 |
1 similar comment
+1 |
Hi @sw-joelmut, have you started a branch to upgrade Zod to 3.22.4? I have a project that is blocked, due to this CVE, from going to production this week. Can you help me to look into this issue please, thank you. |
Hi @hieumoscow, We are working on this, we'll have news soon. |
Hi @sw-joelmut, took me a bit of time to upgrade and test locally, it seems to run fine and parses the test. However there is 1 test at the CloudAdapter Test that the stub seems unable to get the desired expired error message.
Could you please help me review. Pardon me for anythings that I might have missed out as it is my first time contributing to this repo. |
hi I check the Pull request proposed by @hieumoscow , it seems this PR is try to merge code to 4.21.release of bot kit. |
* remove zod in botbuilder-dialogs * update support for TS * update botbuilder api signature * update bf-schema api signature * set zod versions * remove skip * fix lint --------- Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
What is the release version and date for this change to be made available for consumption? |
* remove zod in botbuilder-dialogs * update support for TS * update botbuilder api signature * update bf-schema api signature * set zod versions * remove skip * fix lint --------- Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com> # Conflicts: # libraries/botframework-schema/etc/botframework-schema.api.md # testing/consumer-test/run.ts # yarn.lock
* update zod in botbuilder * change ts support in test consumer * fix ts config * simplify use of safeParse * fix lint --------- Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com> # Conflicts: # libraries/botframework-schema/package.json
Is your feature request related to a problem? Please describe.
The
zod
version (1.11.17
) used across the project has a security vulnerability, which gets picked up by various scanners, e.g. https://security.snyk.io/vuln/SNYK-JS-ZOD-5925617 and it is also over two years old.Describe the solution you'd like
Please upgrade to
v3.x
release line (first released some 2+ years ago).Describe alternatives you've considered
n/a
Additional context
Would it make sense to turn on Renovate (or change Dependabot config) for this project? There does not seem be a clearly visible dependency upgrade strategy in place.
The text was updated successfully, but these errors were encountered: