Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root package.json needs to be cleaned up #926

Closed
stevengum opened this issue May 14, 2019 · 0 comments · Fixed by #1018
Closed

root package.json needs to be cleaned up #926

stevengum opened this issue May 14, 2019 · 0 comments · Fixed by #1018
Assignees
Labels
4.5 P3 P3 Work Item

Comments

@stevengum
Copy link
Member

stevengum commented May 14, 2019

Versions

master branch

Describe the bug

The package.json at the root of the project can be cleaned up:

  1. Old dependencies
    • ms-rest-js and ms-rest-azure (these packages are now namespaced under @azure)
  2. Version mismatches between dependencies and devDependencies
    • dependencies: "typescript": "^3.1.1"
    • devDependencies: "typescript": "^2.7.2"
  3. It's unclear why we have devDependencies in the root package.json as these dependencies are most likely going to be installed anyways when a developer forks and clones the project. Instead of devDependencies and dependencies, there should just be dependencies.

Additional Context

Originally found in #925

[bug]

@stevengum stevengum added the 4.5 label May 14, 2019
@gabog gabog added the P3 P3 Work Item label May 15, 2019
stevengum pushed a commit that referenced this issue Jun 27, 2019
* Cleaned up and updated `package.json` packages

* Update eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5 P3 P3 Work Item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants