add at mention removal code and used it in inspection #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note I haven't included update package-lock files here. |
cleemullins
approved these changes
Jul 3, 2019
|
Holding off Merging, as the comment indicates more testing is required. |
|
tested end to end with Teams - found and fixed one issue see later commits |
stevengum
reviewed
Jul 3, 2019
| * const mentions = TurnContext.getMentions(context.request); | ||
| * ``` | ||
| * @param activity The activity to alter the text on | ||
| * @param id The recipient id of the at mention |
stevengum
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript equivalent of C# microsoft/botbuilder-dotnet#2060
Unit tests included - however this needs more manual testing with Teams tomorrow. Specifically need to validate the exact shape of the activity coming in from Teams regarding the entities that carry additional at mention metadata.
I think the at mention removal code looks a little sketchy (looks like it could stamp on data accidentally?) but for now this code is exactly the same as the C# right down to the use of look-ahead/behind regex.