QnAMakerService correctly builds hostname URL & throws error w/o URL #1035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #939
Description
Issue 1: URL built for hostname would always append "
/qnamaker
" toQnAMakerService.hostname
, even when thehostname
already had/qnamaker
in the hostname string/qnamaker
to hostname, if it does not end in/qnamaker
alreadyhttps://myservice.azurewebsites.net
=>https://myservice.azurewebsites.net/qnamaker
https://MyServiceThatDoesntNeedAppending.azurewebsites.net/qnamaker
remains the sameIssue 2: previously if
QnAMakerService
's first parameter receives asource
that does not have ahostname
, in the URL class's logic, it would throw invalid URL error when constructing URL + base to createQnAMakerService.hostname