Change TS output to ES6 for all libraries #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 84669
💛 - Coveralls |
|
@jspruance can you add this change to your PR? |
@stevengum I've added your changes to the PR |
|
Could this be ES6 instead? We have ES6 features (such as in the RegEx). The browsers we target all (likley) support ES6. |
|
Conerns are (specifically) that runtime features such as the regex look-ahead, which is used in the recognizers-text, need ES6 features. These features cannot be polyfilled. |
added 2 commits
October 15, 2019 15:05
Merge branch 'ts-compile-to-es5' of https://github.com/microsoft/botbuilder-js into ts-compile-to-es5
|
This has been updated to es6. Tested in browser echo bot and unit tests passed. |
stevengum
changed the title
stevengum
approved these changes
Oct 21, 2019
stevengum
requested changes
Oct 21, 2019
stevengum
changed the title
This is complete - ready for review. |
stevengum
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue:
#1076
'botbuilder-core' TS compiler modified to output 'ES5' instead of 'ESNext':
"target": "ES5",
"lib": [ "es2015", "dom" ]
Unit tests pass and browser bot runs with no errors in Chrome (JS errors in IE11 before and after this change).
Note that this change does not guarantee 100% ES5 compatibility since TypeScript compilation only targets syntax and does not do any polyfilling (in contrast, Babel does both). However this should not introduce any new errors - if anything ESNext --> ES5 should be safer.
We could introduce a Babel layer to achieve complete ES5 compatibility, which would look like:
TS > ES6 > Babel > ES5