Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TeamsActivityHandler with refactored ActivityHandler class #1236

Merged
merged 25 commits into from
Oct 2, 2019
Merged

Refactor TeamsActivityHandler with refactored ActivityHandler class #1236

merged 25 commits into from
Oct 2, 2019

Conversation

stevengum
Copy link
Member

Fixes #

Description

Specific Changes

Testing

@stevengum
improve extensibility for ConversationUpdate logic
d0b6521
@stevengum
rewrite and add "virtual" methods to ActivityHandler
f6bbfc3
@stevengum
add new tests for default dispatching logic
e74a909
@stevengum
add more tests, restructure test helpers
1242195
@stevengum
add ActivityHandlerBase and tests
76ba4bb
@stevengum
add tests for ActivityHandlerBase
f2ff344
@stevengum
update docstrings in ActivityHandler
a2a5cf6
@stevengum
add MessageReaction and ConversatioUpdate subtype support
7e36013
@stevengum
remove eventing for invokes from TeamsActivityHandler
44a0074
@stevengum
Merge branch 'master' into stgum/rewrite
52fd1a9
@stevengum
remove eventing for invokes from TeamsActivityHandler
9d0abff
@stevengum
add Teams specific ConversationUpdate events
4ae4cbf
@stevengum
Merge branch 'stgum/TeamsHandler' of https://github.com/microsoft/bot…
239600f 
…builder-js into stgum/TeamsHandler
@stevengum
complete Teams-ConversationUpdate handling, add more tests
dafe660
@stevengum
remove irrelevant TeamsActivityHandler tests
b637ede
@stevengum
Merge branch 'master' into stgum/TeamsHandler
74900a3
@coveralls
Copy link

coveralls commented Oct 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 81401

  • 54 of 129 (41.86%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 87.5%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/teamsTurnContextHelpers.ts 11 12 91.67%
libraries/botbuilder/src/teamsActivityHandler.ts 30 104 28.85%
Totals Coverage Status
Change from base Build 81338: 1.0%
Covered Lines: 4505
Relevant Lines: 4961
💛 - Coveralls

daveta
daveta approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@daveta daveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! We can follow up with the http status thing tomorrow..

@stevengum stevengum merged commit 62a527c into master Oct 2, 2019
@stevengum stevengum deleted the stgum/TeamsHandler branch October 2, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveta daveta daveta approved these changes

@tsuwandy tsuwandy Awaiting requested review from tsuwandy

@johnataylor johnataylor Awaiting requested review from johnataylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @daveta