Fix the content type on the wire to be consistent with the C# implemetation. #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation. The C# implementation expects the content-type to be called "type"
Pull Request Test Coverage Report for Build 81331
💛 - Coveralls |
DDEfromOR
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
CK ran me through his compatibility tests. In short, the C# library uses contentType as the var name, but type as the json tag. The later has been kept to maintain backwards compatibility after I changed the var name out of a personal bias against naming something 'type'. If we touch this again I suggest TypeyMcTypeFace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C# implementation expects the content-type to be called "type".