Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Teams Handler for task/fetch and submit | TaskModule scenario #1242

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Oct 2, 2019

Fixes # #1212

Description

  • Fixes Teams Handler for Invoke/task/fetch and Invoke/task/submit.
    • task/submit now returns TaskModuleResponseBase, which can be used to return type message or continue.
    • Following demonstrates returning a message which casts to base class.
    protected async onTeamsTaskModuleSubmit(context: TurnContext, taskModuleRequest: TaskModuleRequest): Promise<TaskModuleResponseBase | void> {
        var reply = MessageFactory.text("OnTeamsTaskModuleFetchAsync Value: " + JSON.stringify(taskModuleRequest));
        await context.sendActivity(reply);
        var response : TaskModuleMessageResponse = { type: "message", value: "Hello", };
        return <TaskModuleResponseBase> response ;
    }
  • Scenario TaskModule, which demonstrates task fetch/submit.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 81532

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 87.465%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/teamsActivityHandler.ts 0 6 0.0%
Totals Coverage Status
Change from base Build 81402: -0.04%
Covered Lines: 4505
Relevant Lines: 4964

💛 - Coveralls

@daveta daveta merged commit 9203c24 into master Oct 2, 2019
@daveta daveta deleted the daveta-card-bot branch October 2, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants