-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Teams] ComposeMessageExtensionAuthBot teams scenario #1250
Conversation
Pull Request Test Coverage Report for Build 81777
💛 - Coveralls |
...botbuilder/tests/teams/composeMessagingExtensionAuth/src/composeMessagingExtensionAuthBot.ts
Show resolved
Hide resolved
...botbuilder/tests/teams/composeMessagingExtensionAuth/src/composeMessagingExtensionAuthBot.ts
Outdated
Show resolved
Hide resolved
...botbuilder/tests/teams/composeMessagingExtensionAuth/src/composeMessagingExtensionAuthBot.ts
Show resolved
Hide resolved
libraries/botbuilder/tests/teams/composeMessagingExtensionAuth/teams-app-manifest/manifest.json
Outdated
Show resolved
Hide resolved
libraries/botbuilder/tests/teams/composeMessagingExtensionAuth/teams-app-manifest/manifest.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address Tien's feedback before merging this.
Addressing tsuwandy's feedback is required before this PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Eric!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eric!!
Dismissing ... Tien has approved
}] | ||
} | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got into the practice of casting (so you get some sense of what each block is) - for example:
public static toComposeExtensionResultResponse(cardAttachment: Attachment) : MessagingExtensionActionResponse {
return <MessagingExtensionActionResponse> {
composeExtension: <MessagingExtensionResult> {
type: 'result',
attachmentLayout: 'list',
attachments: [ <MessagingExtensionAttachment> cardAttachment ]
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be better ... i've just been casting the top level return, but should be casting the fields too, you're right!
Fixes: #1239