-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Teams] Office365 Connector Card Scenario #1255
Conversation
Pull Request Test Coverage Report for Build 81982
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my feedback about the console logging.
Thanks for adding CardFactory.o365ConnectorCard()
!
libraries/botbuilder/tests/teams/office365Card/src/office365CardsBot.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder/tests/teams/office365Card/src/office365CardsBot.ts
Outdated
Show resolved
Hide resolved
added o365ConnectorCard test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the schema seems to be a mismatch with the json we are generating from dotnet sample is not compatible. Do we need to regenerate them? Will just comment it out for now.
@tsuwandy the problem was that some actions and inputs needed to be <typed>
as the base class didn't contain all of the potential properties. The new types I added to the file should have addressed all of the issues.
There were also some other issues in the values for some of the types, I think due to the fact that the JSON used was copied from the C#-generated JSON. I had to fix those issues (e.g. "MultichoiceInput" -> "multichoiceInput"
, or "TextInput" -> "textInput"
) to get the additional typing to work.
Fixes #1202
Description
Teams Office 365 Connector Bot