Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teams] Office365 Connector Card Scenario #1255

Merged
merged 8 commits into from
Oct 7, 2019
Merged

[Teams] Office365 Connector Card Scenario #1255

merged 8 commits into from
Oct 7, 2019

Conversation

tsuwandy
Copy link
Contributor

@tsuwandy tsuwandy commented Oct 4, 2019

Fixes #1202

Description

Teams Office 365 Connector Bot

@coveralls
Copy link

coveralls commented Oct 4, 2019

Pull Request Test Coverage Report for Build 81982

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 86.541%

Totals Coverage Status
Change from base Build 81970: 0.002%
Covered Lines: 4592
Relevant Lines: 5107

💛 - Coveralls

@stevengum stevengum added 4.6 4.6 release teams labels Oct 4, 2019
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my feedback about the console logging.

Thanks for adding CardFactory.o365ConnectorCard()!

@stevengum stevengum changed the title office 365 connector card bot [Teams] Office365 Connector Card Scenario Oct 4, 2019
@tsuwandy tsuwandy requested a review from stevengum October 4, 2019 20:08
@tsuwandy tsuwandy requested a review from daveta October 5, 2019 00:56
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the schema seems to be a mismatch with the json we are generating from dotnet sample is not compatible. Do we need to regenerate them? Will just comment it out for now.

(original comment)

@tsuwandy the problem was that some actions and inputs needed to be <typed> as the base class didn't contain all of the potential properties. The new types I added to the file should have addressed all of the issues.

There were also some other issues in the values for some of the types, I think due to the fact that the JSON used was copied from the C#-generated JSON. I had to fix those issues (e.g. "MultichoiceInput" -> "multichoiceInput", or "TextInput" -> "textInput") to get the additional typing to work.

@stevengum stevengum merged commit 22b2273 into master Oct 7, 2019
@stevengum stevengum deleted the tiens-o365card branch October 7, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 4.6 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port O365 Cards from C# to JS
4 participants