Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teams] Add update and delete bot scenario #1260

Merged
merged 6 commits into from
Oct 7, 2019
Merged

[Teams] Add update and delete bot scenario #1260

merged 6 commits into from
Oct 7, 2019

Conversation

EricDahlvang
Copy link
Member

@EricDahlvang EricDahlvang commented Oct 4, 2019 •
edited by stevengum
Loading

Fixes #1199

@coveralls
Copy link

coveralls commented Oct 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 81988

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.541%
Totals Coverage Status
Change from base Build 81985: 0.0%
Covered Lines: 4592
Relevant Lines: 5107
💛 - Coveralls

@EricDahlvang EricDahlvang mentioned this pull request Oct 4, 2019
Closed
stevengum
stevengum requested changes Oct 5, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some styling issues...

libraries/botbuilder/tests/teams/activityUpdateAndDelete/src/activityUpdateAndDeleteBot.ts Outdated Show resolved Hide resolved
libraries/botbuilder/tests/teams/activityUpdateAndDelete/src/activityUpdateAndDeleteBot.ts Outdated Show resolved Hide resolved
libraries/botbuilder/tests/teams/activityUpdateAndDelete/src/activityUpdateAndDeleteBot.ts Outdated Show resolved Hide resolved
libraries/botbuilder/tests/teams/activityUpdateAndDelete/src/activityUpdateAndDeleteBot.ts Outdated Show resolved Hide resolved
@EricDahlvang EricDahlvang added 4.6 4.6 release teams labels Oct 5, 2019
@EricDahlvang EricDahlvang requested a review from stevengum October 7, 2019 15:59
@stevengum stevengum merged commit 536c4f0 into master Oct 7, 2019
@stevengum stevengum deleted the eric/addUpdateAndDeleteBot branch October 7, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

@daveta daveta Awaiting requested review from daveta

@tsuwandy tsuwandy Awaiting requested review from tsuwandy

@Virtual-Josh Virtual-Josh Awaiting requested review from Virtual-Josh

Assignees
No one assigned
Labels
4.6 4.6 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port Activity Update & Delete scenario to JS
3 participants
@EricDahlvang @coveralls @stevengum