Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate ChannelData.aadObjectId property and updated Roster bot after testing #1262

Merged
merged 8 commits into from
Oct 7, 2019

Conversation

tsuwandy
Copy link
Contributor

@tsuwandy tsuwandy commented Oct 5, 2019

Fixes #
Completed/tested roster bot

Description

Specific Changes

Testing

@coveralls
Copy link

coveralls commented Oct 5, 2019

Pull Request Test Coverage Report for Build 81957

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 86.703%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/teamsInfo.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/teamsInfo.ts 2 3.08%
Totals Coverage Status
Change from base Build 81954: -0.02%
Covered Lines: 4600
Relevant Lines: 5105

💛 - Coveralls

@tsuwandy tsuwandy closed this Oct 7, 2019
@tsuwandy tsuwandy reopened this Oct 7, 2019
@tsuwandy tsuwandy merged commit a557fee into master Oct 7, 2019
@tsuwandy tsuwandy deleted the tiens-roster branch October 7, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants