Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typedoc vulnerability #1279

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

enzocano
Copy link
Contributor

@enzocano enzocano commented Oct 9, 2019

Description

The lerna-build process found two vulnerabilities related to the typedoc package. Those vulnerabilities were fixed.
In addition, references to the old botbuilder-core-extensions package were deleted.

Before

image

After

image

Specific Changes

  • typedoc@^0.14.2 ==> typedoc@^0.15.0
  • typedoc-plugin-markdown@^2.0.6 ==> typedoc-plugin-markdown@^2.2.10
  • botbuilder-core-extensions docs deleted from botbuilder-core, botbuilder-testing, and botbuilder packages.

Testing

Running npm run build-docs after changes
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 82392

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.229%

Totals Coverage Status
Change from base Build 82305: 0.0%
Covered Lines: 4633
Relevant Lines: 5111

💛 - Coveralls

@cleemullins cleemullins merged commit 7a75aec into microsoft:master Oct 10, 2019
@enzocano enzocano deleted the fix-typedoc-vulnerability branch October 11, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants