Let WebSocketClient take in a disconnection callback #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 83037
💛 - Coveralls |
DDEfromOR
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
LGTM, the auto reconnect was more of an idea than a feature and having it be managed higher up allows for more flexibility around the reason for the disconnect, which could be important in different use cases of the client. This is also closer to the event emitter pattern used in the C# library.
|
Requesting a review from @compulim for his JS expertise. |
|
I'm going ahead and merging since this change does not impact any existing user except DirectLineJS and I need need this change to unblock myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSocketClient does not give an opportunity for the caller to handle disconnects. This PR changes the constructor to accept a callback thats invoked by WebSocketClient upon disconnect. This allows the caller decide the reconnect policy.