Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the rules for what counts as a well formed GUID. #1294

Merged
merged 5 commits into from
Oct 14, 2019

Conversation

DDEfromOR
Copy link
Member

The previous regex pattern used to determine if a header's identifier GUID was well formed enforced the timestamp based UUID rules as laid out in RFC 4122. The dotnet standard library used in C# bots only requires a GUID to match the 8-4-4-4-12 pattern to be valid, making them less restrictive.

This change relaxes the regex matching to match any GUID following the 8-4-4-4-12 pattern for parity with the C# library.

@coveralls
Copy link

coveralls commented Oct 12, 2019

Pull Request Test Coverage Report for Build 83255

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.976%

Totals Coverage Status
Change from base Build 83243: 0.0%
Covered Lines: 4743
Relevant Lines: 5241

💛 - Coveralls

Copy link
Member

@carlosscastro carlosscastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would love to see a test for the bug that made us find this, or at least specific tests

@DDEfromOR
Copy link
Member Author

Added a test to make sure nil GUIDs are accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants