Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix malformatted user agent JSON #1323

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Fix malformatted user agent JSON #1323

merged 1 commit into from
Oct 18, 2019

Conversation

DDEfromOR
Copy link
Member

Fix to make sure the USER AGENT is sent as properly formatted JSON to in-proc Streaming requests for version information.

@DDEfromOR DDEfromOR requested a review from stevengum October 18, 2019 03:36
stevengum
stevengum approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 84210

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 87.682%
Totals Coverage Status
Change from base Build 84096: 0.06%
Covered Lines: 4847
Relevant Lines: 5317
💛 - Coveralls

@DDEfromOR DDEfromOR merged commit 0efce8d into master Oct 18, 2019
@DDEfromOR DDEfromOR deleted the dev/se-fix branch October 18, 2019 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DDEfromOR @coveralls @stevengum