Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand ChannelAccount to TeamsChannelAccount #1350

Merged
merged 3 commits into from
Oct 23, 2019
Merged

expand ChannelAccount to TeamsChannelAccount #1350

merged 3 commits into from
Oct 23, 2019

Conversation

johnataylor
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 85349

  • 3 of 25 (12.0%) changed or added relevant lines in 1 file are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 85.106%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/teamsActivityHandler.ts 3 25 12.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/teamsActivityHandler.ts 23 41.54%
Totals Coverage Status
Change from base Build 85323: -0.8%
Covered Lines: 4895
Relevant Lines: 5510
💛 - Coveralls

@johnataylor johnataylor requested a review from stevengum October 23, 2019 22:45
@johnataylor
Copy link
Member Author

fixes #1346

@johnataylor johnataylor merged commit c91e93f into master Oct 23, 2019
@johnataylor johnataylor deleted the johtaylo/issue1346 branch October 23, 2019 23:04
@stevengum stevengum added the teams label Nov 7, 2019
@stevengum stevengum mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

@Virtual-Josh Virtual-Josh Awaiting requested review from Virtual-Josh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnataylor @coveralls @stevengum