Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick #1409] Fix for TranscriptLoggerMiddleware not checking responses type #1426

Closed
wants to merge 2 commits into from

Conversation

stevengum
Copy link
Member

Fixes: #1404

Specific Changes

…ing responses type (#1409)

* add test to reproduce issue #1404

* add test or Transcripts where SendActivitiesHandler is not properly implemented

* add bug fix for #1404, more tests

* apply PR feedback and refactor code
@coveralls
Copy link

coveralls commented Nov 18, 2019

Pull Request Test Coverage Report for Build 90565

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 84.325%

Totals Coverage Status
Change from base Build 90307: 0.003%
Covered Lines: 7837
Relevant Lines: 8959

💛 - Coveralls

@stevengum
Copy link
Member Author

Closing as the current logic in master was not released in 4.6. Specifically the logic to stamp over the activity.id with the actual resourceresponse.id. In master we will pick up theses tests and revisit the logic in the TranscriptLoggerMiddleware for R7.

@stevengum stevengum closed this Nov 18, 2019
@stevengum stevengum deleted the stgum/cp-1409 branch February 24, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug, Transcripts] TranscriptLoggerMiddleware should check for responses before checking responses.length
2 participants