Updated Dialog Manager to work with skills #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 144966
💛 - Coveralls |
|
@chon219, I will take a look at this today. Thanks for jumping on it! |
stevengum
previously requested changes
Jun 17, 2020
Comment on lines
+98
to
+103
| export function shouldSendEndOfConversationToParent(context: TurnContext, turnResult: DialogTurnResult): boolean { | ||
| if (!(turnResult.status == DialogTurnStatus.complete || turnResult.status == DialogTurnStatus.cancelled)) { | ||
| // The dialog is still going, don't return EoC. | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
@chon219, this is a combination that combines DialogManager.ShouldSendEndOfConversationToParent() and DialogExtensions.SendEoCToParent(), correct?
I think we should also take this change in C#. What do you think @gabog?
There was a problem hiding this comment.
@stevengum I think so. We have two implementations of this function in c# but it seems that we only need one.
stevengum
reviewed
Jul 1, 2020
chon219
requested review from
boydc2014,
carlosscastro,
chrimc62 and
luhan2017
as code owners
stevengum
requested changes
Jul 3, 2020
stevengum
reviewed
Jul 3, 2020
stevengum
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1970
Fixes #2263
Description
Updated DialogManager to support skills
Specific Changes
Testing
Added tests for Dialog Manager to cover skills