Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: config argv source, runtime port handling #3406

Merged
merged 3 commits into from
Mar 18, 2021
Merged

feat: config argv source, runtime port handling #3406

merged 3 commits into from
Mar 18, 2021

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Mar 17, 2021 •
edited
Loading

Encapsulate port handling that has leaked into the generators (see here).

Fixes #3407

@joshgummersall joshgummersall requested a review from a team as a code owner March 17, 2021 17:44
@joshgummersall joshgummersall force-pushed the jpg/runtime-argv-config-source branch from 28dbb82 to 356dd9a Compare March 17, 2021 18:02
@coveralls
Copy link

coveralls commented Mar 17, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 662855228

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 85.087%
Totals Coverage Status
Change from base Build 662732692: 0.06%
Covered Lines: 18786
Relevant Lines: 21032
💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/runtime-argv-config-source branch 5 times, most recently from 79d41a8 to be74f13 Compare March 17, 2021 22:31
@joshgummersall joshgummersall force-pushed the jpg/runtime-argv-config-source branch from be74f13 to 1d5cded Compare March 17, 2021 22:58
stevengum
stevengum approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joshgummersall joshgummersall merged commit f3664b5 into main Mar 18, 2021
@joshgummersall joshgummersall deleted the jpg/runtime-argv-config-source branch March 18, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encapsulate env/flag override logic from runtime generators
3 participants
@joshgummersall @coveralls @stevengum