-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adaptive-expressions' refinements #3410
Conversation
if (instance === undefined) { | ||
result = true; | ||
} else if (typeof instance === 'string') { | ||
let result = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isEmpty(undefined)
returns false
here - is that the intended behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is indeed a small bug for empty. I create an independent issue here: microsoft/botbuilder-dotnet#5337. I would drop the chage of "empty" for this pr, and would port it after C# side is done. Thank.
Specific Changes
lodash
, replaced with native function.float
andint
to support number and bigint inputticksToDays
,ticksToHours
,ticksToMinutes
to support bigint format inputunique
FunctionUtils.isNumber(arg)
to check number== null
and!= null
to check nil valuecommonStringfy
help function