Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adaptive-expressions' refinements #3410

Merged
merged 6 commits into from
Mar 23, 2021
Merged

adaptive-expressions' refinements #3410

merged 6 commits into from
Mar 23, 2021

Conversation

Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Mar 18, 2021

Specific Changes

  • Drop lodash, replaced with native function.
  • Make float and int to support number and bigint input
  • Make ticksToDays, ticksToHours, ticksToMinutes to support bigint format input
  • Add list verify in function unique
  • Use FunctionUtils.isNumber(arg) to check number
  • Use == null and != null to check nil value
  • Extract commonStringfy help function

@Danieladu Danieladu requested review from joshgummersall, stevengum and a team as code owners March 18, 2021 08:07
@coveralls
Copy link

coveralls commented Mar 18, 2021

Pull Request Test Coverage Report for Build 678314554

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 131 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.08%) to 85.116%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/builtinFunctions/concat.ts 1 94.59%
libraries/adaptive-expressions/src/builtinFunctions/float.ts 1 88.46%
libraries/adaptive-expressions/src/builtinFunctions/ticksToDays.ts 1 87.5%
libraries/adaptive-expressions/src/builtinFunctions/ticksToHours.ts 1 87.5%
libraries/adaptive-expressions/src/builtinFunctions/ticksToMinutes.ts 1 87.5%
libraries/adaptive-expressions/src/constant.ts 2 91.53%
libraries/adaptive-expressions/src/parser/expressionParser.ts 2 95.98%
libraries/botbuilder-lg/src/templates.ts 3 93.85%
libraries/adaptive-expressions/src/functionUtils.internal.ts 8 93.85%
libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts 24 75.79%
Totals Coverage Status
Change from base Build 665654550: 0.08%
Covered Lines: 18796
Relevant Lines: 21031

💛 - Coveralls

if (instance === undefined) {
result = true;
} else if (typeof instance === 'string') {
let result = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isEmpty(undefined) returns false here - is that the intended behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is indeed a small bug for empty. I create an independent issue here: microsoft/botbuilder-dotnet#5337. I would drop the chage of "empty" for this pr, and would port it after C# side is done. Thank.

@joshgummersall joshgummersall merged commit c76d081 into main Mar 23, 2021
@joshgummersall joshgummersall deleted the hond/refinement branch March 23, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants