-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port: resume dialog fix from .net #3525
Conversation
Pull Request Test Coverage Report for Build 721154294
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
@@ -0,0 +1,148 @@ | |||
{ | |||
"$schema": "../../../tests.schema", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems odd, @Danieladu @chon219 @joshgummersall is there a reason we don't have a central version of this test.schema
hosted somewhere? (Like https://schemas.botframework.com/schemas/component/v1.0/component.schema)
Not blocking on this comment, just wondering if this can be tightened up. Especially since the JS SDK's AdaptiveDialog/Declarative parity is closer than it's ever been with the .NET SDK.
Fixes #3524