-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cloud Adapter for streaming tests #3835
Conversation
Pull Request Test Coverage Report for Build 994166019
💛 - Coveralls |
Note: once this lands I'll reconfigure the ADO pipeline(s) to point to the new location. |
0, | ||
3 | ||
0, | ||
3 | ||
)}...${DIRECT_LINE_SECRET.substr(-3)}"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe either DIRECT_LINE_SECRET?.substr(-3)
or do an argument check (if not already done elsewhere) prior to this step? There's a couple of these calls in this function. Although it looks like it'll send a 500 prior to this step if it's empty. I'm not sure how clear the err.message is for an empty token, though.
Upon further inspection, it might be good to throw in generateDirectlineToken()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to keep this change scoped to just Cloud Adapter. As this is code for CI, I think it's okay to expect the environment is set up correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending the one unresolved comment I left.
testing
directoryBotFrameworkAdapter
withCloudAdapter
#minor