fix: configuration key handling #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds some tests to ensure future consistency.
mdrichardson
reviewed
Jul 8, 2021
libraries/botbuilder-dialogs-adaptive-runtime/test/configuration.test.ts
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 1013016424
💛 - Coveralls |
Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
stevengum
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3840 introduced an issue with configuration key handling that broke the behavior of
.get(). This PR fixes that handling and adds tests to ensure the behavior remains consistent going forward. The code was not released as part of 4.14 so it doesn't need patching.#minor