Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace stdlib assertions with zod #3859

Merged
merged 2 commits into from
Jul 29, 2021
Merged

chore: replace stdlib assertions with zod #3859

merged 2 commits into from
Jul 29, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3670

@joshgummersall joshgummersall requested review from stevengum and a team as code owners July 9, 2021 15:46
@joshgummersall joshgummersall force-pushed the jpg/stdlib-zod branch 4 times, most recently from cf06260 to 5f5cddb Compare July 9, 2021 16:06
@coveralls
Copy link

coveralls commented Jul 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1068246701

  • 91 of 132 (68.94%) changed or added relevant lines in 18 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 84.486%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-core/src/botComponent.ts 3 4 75.0%
libraries/botbuilder-core/src/storage.ts 4 5 80.0%
libraries/botbuilder-dialogs-declarative/src/componentDeclarativeTypes.ts 2 4 50.0%
libraries/botframework-connector/src/auth/userTokenClientImpl.ts 1 7 14.29%
libraries/botframework-connector/src/auth/botFrameworkClientImpl.ts 3 10 30.0%
libraries/botframework-schema/src/index.ts 38 62 61.29%
Totals Coverage Status
Change from base Build 1060315416: 0.2%
Covered Lines: 19573
Relevant Lines: 21939
💛 - Coveralls

stevengum
stevengum approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit 3dc3d7e into main Jul 29, 2021
@stevengum stevengum deleted the jpg/stdlib-zod branch July 29, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace botbuilder-stdlib assertions with zod
3 participants
@joshgummersall @coveralls @stevengum