fix: blobs transcript date filter #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
commented
Jul 21, 2021
| @@ -141,8 +141,7 @@ export class BlobsTranscriptStore implements TranscriptStore { | |||
| const fromIdx = | |||
| startDate != null | |||
| ? blobItems.findIndex( | |||
| (blobItem) => | |||
| blobItem?.metadata?.timestamp && new Date(blobItem.metadata.timestamp) >= startDate | |||
| (blobItem) => blobItem?.properties?.createdOn && blobItem?.properties?.createdOn >= startDate | |||
There was a problem hiding this comment.
I logged the blobItems array and found that metadata is undefined by default, so I opted for this property that does exist. I tested against a real blob storage container.
There was a problem hiding this comment.
Is createdOn already a Date() obj?
This change still works with local storage emulation, too?
There was a problem hiding this comment.
It is, yes. I'll test with the emulator as well. It should as the Typescript type definitions should be correct. Will double check though.
There was a problem hiding this comment.
@mdrichardson Emulator checks out!
joshgummersall
commented
Jul 21, 2021
| @@ -5,7 +5,7 @@ import * as z from 'zod'; | |||
| import getStream from 'get-stream'; | |||
| import pmap from 'p-map'; | |||
| import { Activity, PagedResult, TranscriptInfo, TranscriptStore } from 'botbuilder-core'; | |||
| import { maybeCast } from 'botbuilder-stdlib/lib/maybeCast'; | |||
| import { maybeCast } from 'botbuilder-stdlib'; | |||
There was a problem hiding this comment.
Simple fix here, auto-import included the wrong path before.
Pull Request Test Coverage Report for Build 1054042577
💛 - Coveralls |
mdrichardson
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3864