Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prerelease for date instead of metadata #3879

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

joshgummersall
Copy link
Contributor

MyGet and npm have inconsistent handling for semver metadata which causes several nightly tests to fail. Let's revert to
prerelease for dates.

#minor

MyGet and npm have inconsistent handling for semver metadata which causes several nightly tests to fail. Let's revert to
prerelease for dates.
@joshgummersall joshgummersall requested review from stevengum and a team as code owners July 22, 2021 16:47
@coveralls
Copy link

coveralls commented Jul 22, 2021

Pull Request Test Coverage Report for Build 1056922418

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.325%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 1054226198: 0.0%
Covered Lines: 19685
Relevant Lines: 22143

💛 - Coveralls

@joshgummersall joshgummersall merged commit ff2d770 into main Jul 22, 2021
@joshgummersall joshgummersall deleted the jpg/revert-to-prerelease-dates branch July 22, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants