Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: date precedence for semver sorting #3880

Merged
merged 1 commit into from
Jul 23, 2021
Merged

fix: date precedence for semver sorting #3880

merged 1 commit into from
Jul 23, 2021

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Jul 23, 2021 •
edited
Loading

Bruce educated me on semver sorting, so here's one more small fix along with a unit test 😄

#minor

@joshgummersall joshgummersall requested review from stevengum and a team as code owners July 23, 2021 15:44
mdrichardson
mdrichardson approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@mdrichardson mdrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooh. I like the idea of using semver in the actual tests.

@joshgummersall
Copy link
Contributor Author

Yeah, I figured I may as well do myself a favor here so I know I'm doing the right thing.

@joshgummersall joshgummersall merged commit c56bbf1 into main Jul 23, 2021
@joshgummersall joshgummersall deleted the jpg/fix-semver-sort-issue branch July 23, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgummersall @mdrichardson