Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3890] createConnectorClient function is not getting the correct ConnectorFactory #3891

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #3890

Description

This PR fixes an issue in the createConnectorClient function that is not retrieving the correct ConnectorFactory and instead the UserTokenClient. By changing the key to obtain the factory from UserTokenClientKey to ConnectorFactoryKey solved the issue.

Specific Changes

  • Updated the createConnectorClient to retrieve the CardFactory using the ConnectorFactoryKey instead of UserTokenClientKey key.

Testing

The following image shows the error thrown when trying to create the ConnectorClient and the new unit tests.
imagen
imagen

@sw-joelmut sw-joelmut requested review from a team as code owners August 2, 2021 18:15
@sw-joelmut sw-joelmut requested review from Stevenic and chrimc62 August 2, 2021 18:15
@coveralls
Copy link

coveralls commented Aug 2, 2021

Pull Request Test Coverage Report for Build 1091703111

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 84.509%

Totals Coverage Status
Change from base Build 1091523071: 0.009%
Covered Lines: 19633
Relevant Lines: 22005

💛 - Coveralls

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One quick comment on the test, otherwise it's ready to land.

@joshgummersall joshgummersall merged commit 8ede831 into microsoft:main Aug 2, 2021
@ceciliaavila ceciliaavila deleted the southworks/fix/create-connector-client branch August 3, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createConnectorClient function is not getting the correct ConnectorFactory
3 participants