fix: [botbuilder-core] TestAdapter throws unhandled promise rejection on error #3990
+48
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrecuenco
force-pushed
the
test-adapter-unhandled-rejection
branch
4 times, most recently
from
c0fb83b to
447a103
Compare
|
Working around this bug on the testing framework is a bit painful currently, since we can't test that the application recovers correctly after unexpected errors. |
alexrecuenco
changed the title
alexrecuenco
force-pushed
the
test-adapter-unhandled-rejection
branch
from
447a103 to
fa5cc81
Compare
alexrecuenco
force-pushed
the
test-adapter-unhandled-rejection
branch
3 times, most recently
from
b0289af to
73eb9f7
Compare
|
@joshgummersall , I rebased on main and fixed the issues raised. Thank you for your time |
alexrecuenco
force-pushed
the
test-adapter-unhandled-rejection
branch
from
73eb9f7 to
f1b773d
Compare
mrivera-ms
changed the title
Pull Request Test Coverage Report for Build 1931446834
💛 - Coveralls |
Description TestAdapter throws unhalded promise rejections on errors - The testadapter should handle errors - For that, TestFlow must implement the thenable implementation correctly Specific Changes - Implemented further the tenable on TestFlow to allow handling catch clauses correctly Testing A test is added to verify the behavior change (If you run that test on main before this PR is merged, it fails)
alexrecuenco
force-pushed
the
test-adapter-unhandled-rejection
branch
from
3b58c97 to
ad397d6
Compare
|
Rebased again and pushed the api change as obtained running |
- Ran yarn test:compat --local
alexrecuenco
force-pushed
the
test-adapter-unhandled-rejection
branch
from
ad397d6 to
0d3aac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestAdapter throws unhalded promise rejections on errors
Specific Changes
Testing
A test is added to verify the behavior change (If you run that test on main before this PR is merged, it fails)
#minor