Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4007] Bot framework V4. Unable to use ⭐ emoji in suggested actions #4031

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4007

Description

This PR ports the changes in dotnet PR#4671 to add the findExactMatch function in botbuilder-dialogs/choices to check for exact matches and bypass the tokenizer logic if an exact match is found.

Specific Changes

  • Updated findValues class to check for exact matches and bypass the rest of its logic if an exact match is found.
  • Added a test to account for situations where multiple choices have the same word characters but different non-word characters.

Testing

These images show the star choice being ignored, and after the fix, being properly recognized.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 20, 2021 14:45
@coveralls
Copy link

coveralls commented Dec 20, 2021

Pull Request Test Coverage Report for Build 1602553546

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 84.545%

Totals Coverage Status
Change from base Build 1594509170: 0.002%
Covered Lines: 19667
Relevant Lines: 22035

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 5909b69 into main Jan 3, 2022
@mrivera-ms mrivera-ms deleted the southworks/add/dialogs-choices-findexactmatch branch January 3, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot framework V4. Unable to use ⭐ emoji in suggested actions
3 participants