Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2745] Fix current eslint warnings - adaptive-expressions library (1/2) #4034

Merged
merged 5 commits into from
Jan 31, 2022

Conversation

ceciliaavila
Copy link
Collaborator

@ceciliaavila ceciliaavila commented Dec 30, 2021

Addresses #2745
#minor

Description

This PR fixes the ESLint and JSDoc issues in the adaptive-expressions library.

Note: we excluded the @typescript-eslint/no-explicit-any and @typescript-eslint/explicit-module-boundary-types to tackle those issues as a separated task as they require deeper analysis and testing.

Specific Changes

  • Applied the eslint auto-fix with yarn lint --fix (quotes, spacing, replaced var with let)
  • Added missing JSDoc documentation in methods.
  • Removed unused imports and variables.
  • Disabled @typescript-eslint/ban-types rule to review the use of object along with the any types.
  • Disabled prefer-const rule in builtinFunctions/rand.ts as the variables can't be replaced with const.
  • Disabled security/detect-non-literal-regexp rule as the variables are needed to create the regex dynamically.
  • Moved variables with requires to the import section.

Testing

This image shows the tests passing after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 30, 2021 17:00
@coveralls
Copy link

coveralls commented Dec 30, 2021

Pull Request Test Coverage Report for Build 1775098272

  • 66 of 66 (100.0%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.546%

Totals Coverage Status
Change from base Build 1757731723: 0.4%
Covered Lines: 19668
Relevant Lines: 22036

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 5efa0a8 into main Jan 31, 2022
@mrivera-ms mrivera-ms deleted the southworks/fix/eslint/adaptive-expressions-1 branch January 31, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants