Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2745] Fix current eslint warnings - botbuilder library #4037

Merged

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #2745
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder library.

Note: we excluded the @typescript-eslint/no-explicit-any and @typescript-eslint/explicit-module-boundary-types to tackle those issues as a separated task as they require deeper analysis and testing.

Specific Changes

  • Applied the eslint auto-fix with yarn lint --fix (quotes, spacing, replaced var with let)
  • Added missing JSDoc documentation in methods.
  • Removed unused imports and variables.

Testing

All tests passes after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner January 3, 2022 13:00
@coveralls
Copy link

coveralls commented Jan 3, 2022

Pull Request Test Coverage Report for Build 1775496719

  • 30 of 32 (93.75%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 84.546%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/botFrameworkAdapter.ts 24 26 92.31%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 1775491407: -0.003%
Covered Lines: 19668
Relevant Lines: 22036

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit d55b5b9 into main Feb 1, 2022
@mrivera-ms mrivera-ms deleted the southworks/fix/current-eslint-warnings-botbuilder-library branch February 1, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants