Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update botbuilder-js-daily.yml #4048

Merged
merged 2 commits into from
Jan 10, 2022
Merged

chore: Update botbuilder-js-daily.yml #4048

merged 2 commits into from
Jan 10, 2022

Conversation

munozemilio
Copy link
Member

#minor

@munozemilio munozemilio requested a review from a team as a code owner January 10, 2022 18:06
@coveralls
Copy link

coveralls commented Jan 10, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1679522539

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.545%
Totals Coverage Status
Change from base Build 1669432984: -0.003%
Covered Lines: 19667
Relevant Lines: 22035
💛 - Coveralls

mrivera-ms
mrivera-ms reviewed Jan 10, 2022
View reviewed changes
build/yaml/botbuilder-js-daily.yml Outdated
failOnAlert: false
sourceScanPath: './libraries'
ignoreDirectories: './testing,./tools'
failOnAlert: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set this to false as there may be some issues that will remain.

@munozemilio
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@munozemilio munozemilio merged commit 881b018 into main Jan 10, 2022
@munozemilio munozemilio deleted the munozemilio/set-path-CG branch January 10, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrivera-ms mrivera-ms mrivera-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@munozemilio @coveralls @mrivera-ms