Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node-fetch Component Governance vulnerability #4079

Merged
merged 9 commits into from
Feb 11, 2022

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Jan 25, 2022

Fixes #minor

Description

Fixes the high severity node-fetch vulnerability listed in this CG alert:
https://fuselabs.visualstudio.com/SDK_v4/_componentGovernance/112352/alert/6435491?typeId=10220548

Vulnerability: Upgrade node-fetch from 2.6.1 to 2.6.7 to fix the vulnerability.

Force node-fetch to v 2.6.7

Specific Changes

Add a resolutions section to the root package.json.

@BruceHaley BruceHaley requested a review from a team as a code owner January 25, 2022 01:09
@coveralls
Copy link

coveralls commented Jan 25, 2022

Pull Request Test Coverage Report for Build 1826987990

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.546%

Totals Coverage Status
Change from base Build 1809807122: -0.003%
Covered Lines: 19668
Relevant Lines: 22036

💛 - Coveralls

@BruceHaley BruceHaley added the Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. label Jan 25, 2022
package.json Outdated Show resolved Hide resolved
@BruceHaley BruceHaley merged commit 12410df into main Feb 11, 2022
@BruceHaley BruceHaley deleted the bruce/nodefetchfix1-24 branch February 11, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants