Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failing pipeline E2E_BF-Streaming-DL-ASE_Test #4110

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

BruceHaley
Copy link
Contributor

Fixes #minor

Description

react-app@0.1.0 build
react-scripts build
Creating an optimized production build...
Failed to compile.
Module not found: Error: Can't resolve 'stream' in 'D:\a\1\s\testing\streaming-e2e\react-app\node_modules\jws\lib'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:

  • add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }'
  • install 'stream-browserify'
    If you don't want to include a polyfill, you can use an empty module like this:
    resolve.fallback: { "stream": false }

Specific Changes

Switch from npm install react-scripts@latest to npm install react-scripts@4.0.3

@BruceHaley BruceHaley added the bug Indicates an unexpected problem or an unintended behavior. label Feb 9, 2022
@BruceHaley BruceHaley requested a review from a team as a code owner February 9, 2022 18:23
@coveralls
Copy link

coveralls commented Feb 9, 2022

Pull Request Test Coverage Report for Build 1844695657

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.546%

Totals Coverage Status
Change from base Build 1827077824: -0.003%
Covered Lines: 19668
Relevant Lines: 22036

💛 - Coveralls

@BruceHaley BruceHaley closed this Feb 11, 2022
@BruceHaley BruceHaley reopened this Feb 15, 2022
@BruceHaley BruceHaley merged commit fb9a2d2 into main Feb 15, 2022
@BruceHaley BruceHaley deleted the bruce/fixstreamingbuild2-9 branch February 15, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants