Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#3967] add control property (#5943) #4148

Merged
merged 4 commits into from
Mar 17, 2022
Merged

port: [#3967] add control property (#5943) #4148

merged 4 commits into from
Mar 17, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #3967 #3975

Description

This PR ports the changes in BotBuider-DotNet to add the enableFromFile property in the Templates class.

Specific Changes

  • Added enableFromFile property in the Templates class.
  • Added condition for fromFile in customizedEvaluatorLookup method of Evaluator and Expander classes.
  • Added unit test for the FileOperationDisabled scenario.

Testing

This image shows the new tests passing.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner March 8, 2022 17:00
@ceciliaavila ceciliaavila linked an issue Mar 8, 2022 that may be closed by this pull request
port: flip enableFromFile to false by default and fix unit tests (#5953) #3975
Closed
@coveralls
Copy link

coveralls commented Mar 8, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1955059871

  • 7 of 9 (77.78%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0002%) to 84.547%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-lg/src/expander.ts 2 4 50.0%
Totals Coverage Status
Change from base Build 1955056872: 0.0002%
Covered Lines: 19672
Relevant Lines: 22040
💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 57ad9f5 into main Mar 17, 2022
@mrivera-ms mrivera-ms deleted the southworks/add/template-from-file-prop branch March 17, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrivera-ms mrivera-ms mrivera-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: flip enableFromFile to false by default and fix unit tests (#5953) port: add control property (#5943)
3 participants
@ceciliaavila @coveralls @mrivera-ms