Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Obsolete classes for future deprecation #4149

Merged
merged 5 commits into from
Mar 17, 2022
Merged

port: Obsolete classes for future deprecation #4149

merged 5 commits into from
Mar 17, 2022

Conversation

mrivera-ms
Copy link
Contributor

Fixes #4060, #4061, #4108

In this change:

  • Obsolete sidecar debugging classes
  • Add Obsolete attribute to IExtendedUserTokenProvider and IUserTokenProvider
  • Add Obsolete attribute to DialogManager

@mrivera-ms mrivera-ms requested a review from a team as a code owner March 9, 2022 02:30
@coveralls
Copy link

coveralls commented Mar 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2001245576

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.573%
Totals Coverage Status
Change from base Build 1995608014: -0.003%
Covered Lines: 19707
Relevant Lines: 22073
💛 - Coveralls

@mrivera-ms mrivera-ms merged commit f2f811b into main Mar 17, 2022
@mrivera-ms mrivera-ms deleted the moniriv/addobsolete branch March 17, 2022 23:07
This was referenced May 23, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msomanathan msomanathan msomanathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Obsolete sidecar debugging classes (#6132)
3 participants
@mrivera-ms @coveralls @msomanathan