New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#3931] Add "omnichannel" to Channels (#5891) #4153

Merged

mrivera-ms merged 2 commits into main from southworks/add/omnichannel

Mar 11, 2022

Collaborator

ceciliaavila commented Mar 9, 2022

Fixes #3931

Description

This PR adds omnichannel to the Channels enum in botframework-schema.

Specific Changes

Added Omni value to the Channels enum in botframework-schema.
Updated botframework-schema.api.md to include the new channel value.

Testing

This image shows the schema tests passing after including the new channel.

ceciliaavila added 2 commits

March 9, 2022 12:54


          Add omnichannel to Channels

b5b4c5f


          Update comment

02d0fc5

ceciliaavila requested a review from a team as a code owner

March 9, 2022 20:46

coveralls commented Mar 9, 2022 •

edited

Loading

Pull Request Test Coverage Report for Build 1959615570

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 84.547%

Totals
Change from base Build 1955117631:	-0.2%
Covered Lines:	19670
Relevant Lines:	22038

💛 - Coveralls

mrivera-ms approved these changes

View reviewed changes

mrivera-ms merged commit f498114 into main

mrivera-ms deleted the southworks/add/omnichannel branch

March 11, 2022 21:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet