Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4073] Set TeamsNotifyUser Alert to opposite of AlertInMeeting #4165

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4073

Description

This PR updates the alert property for the teamsNotifyUser method notification, to depend on the alertInMeeting property. Additionally, it updates the unit tests to support these changes.

Specific Changes

  • Updates alertInMeeting property default value to be false instead of undefined, when the parameter is not passed in.
  • Updates the alert property notification to be the opposite value of the alertInMeeting property.
  • Updates the unit tests to include the conditions of alertInMeeting and alert properties. Additionally, it updates the naming for some unit tests, to differ from the rest.

Testing

The following image shows the tests passing successfully.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner March 18, 2022 19:06
@coveralls
Copy link

coveralls commented Mar 18, 2022

Pull Request Test Coverage Report for Build 2005953428

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 84.473%

Totals Coverage Status
Change from base Build 2001351852: -0.002%
Covered Lines: 19731
Relevant Lines: 22123

💛 - Coveralls

@gabog
Copy link
Contributor

gabog commented Mar 21, 2022

Hi @EricDahlvang, can you please review this one too?

Thanks

@EricDahlvang EricDahlvang merged commit 4cedd89 into main Mar 21, 2022
@EricDahlvang EricDahlvang deleted the southworks/update/teams-notify-user-alert branch March 21, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Set TeamsNotifyUser Alert to opposite of AlertInMeeting (#6136)
4 participants