Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3192] Missing LICENSE files and invalid package.json - Part 1 #4167

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

sw-joelmut
Copy link
Collaborator

@sw-joelmut sw-joelmut commented Mar 18, 2022

Addresses #3192
#minor

Description

This PR modifies the update-versions script, to take the private packages into account when updating all the libraries versions and references and also the peerDependencies.

Specific Changes

  • Updated update-versions script to gather all the repo packages and update the version for the ones that aren't private.
  • Updated update-versions script to take the peerDependencies into consideration.

@sw-joelmut sw-joelmut requested a review from a team as a code owner March 18, 2022 19:11
@coveralls
Copy link

coveralls commented Mar 21, 2022

Pull Request Test Coverage Report for Build 2022482128

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.473%

Totals Coverage Status
Change from base Build 2019278669: -0.003%
Covered Lines: 19731
Relevant Lines: 22123

💛 - Coveralls

Copy link
Contributor

@gabog gabog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sw-joelmut, can you revert the updates from 4.1.6 to 4.16? We need to determine what version we want to use for dev packages and we can address that in another PR.

@sw-joelmut sw-joelmut force-pushed the southworks/update/packagejson-version branch from 8476aec to b6d9f4d Compare March 22, 2022 13:02
@sw-joelmut
Copy link
Collaborator Author

Hi @sw-joelmut, can you revert the updates from 4.1.6 to 4.16? We need to determine what version we want to use for dev packages and we can address that in another PR.

@gabog, 4.1.6 to 4.16.0 changes reverted, only remains the adjustments for the update-versions script.

Thanks

@tracyboehrer tracyboehrer merged commit 4d04d2c into main Apr 15, 2022
@tracyboehrer tracyboehrer deleted the southworks/update/packagejson-version branch April 15, 2022 13:59
tracyboehrer added a commit that referenced this pull request Apr 15, 2022
* chore(deps): bump moment from 2.29.1 to 2.29.2 (#4184)

Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.1...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump minimist from 1.2.5 to 1.2.6 (#4182)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump minimist (#4181)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update update-versions script to support peerDependencies (#4167)

* fix: Azure Blob transcript key  (#4180)

* Azure Blob sanitizeBlobKey bug fix

* attempt to fix w/ backwards compatibility

* clean up

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Co-authored-by: Ram Fattah <38049078+ramfattah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants