fix: Force dependencies on async to v 3.2.3 - main branch #4194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4188
Description
This fixes the high severity Component Governance alerts for async. Example alert.
The alerts recommend "Upgrade async...to 3.2.2 to fix the vulnerability." V 3.2.3 is now the latest, so using that one.
The parent dependency, adal-node 0.2.3, has no updates available. And migrating to its replacement, ADAL for Node.js, requires code rewrites. So I have tried here forcing the async dependency to a safe version. The adal-node dependency tree:
Specific Changes
Add "async": "3.2.3" to the "resolutions" section of package.json file. Yarn picks that up and forces all dependencies to use that version.
Testing
This fix was incorporated in packages with version number v4.16.0-dev.20220415.369fcc4 and pushed to MyGet for testing.
The packages were tested in the 8 Samples E2E test pipelines for JS and for TS, and they all passed.