Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Critical alert for es5-ext 0.10.60 #4198

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Apr 19, 2022

Fixes #minor

Description

Pipeline E2E_BF-Streaming-DL-ASE_Test is failing in task Component Detection with 1 Malware alert(s) rated at 'Critical’ severity. Malicious component found: es5-ext 0.10.60

npm ls es5-ext
react-app@0.1.0 C:\src\botbuilder-js\testing\streaming-e2e\react-app
`-- react-scripts@4.0.3
  `-- resolve-url-loader@3.1.4
    `-- es6-iterator@2.0.3
      +-- d@1.0.1
      | `-- es5-ext@0.10.60  deduped
      `-- es5-ext@0.10.60

I tried updating react-scripts to v 5.0.1, but that broke the build at step Build React App with "Can't resolve 'stream'".

Specific Changes

Override "es5-ext" downgrading it to "0.10.53". (0.10.60 is the latest version.)

This fix resolves the es5-ext 0.10.60 critical alert and stops the build from failing.

Add Component Governance task. This replaces the injected CG task, which only runs against the main branch. It makes testing CG fixes easier.

@coveralls
Copy link

coveralls commented Apr 19, 2022

Pull Request Test Coverage Report for Build 2187028115

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.482%

Totals Coverage Status
Change from base Build 2172847391: -0.003%
Covered Lines: 19909
Relevant Lines: 22316

💛 - Coveralls

@BruceHaley BruceHaley marked this pull request as ready for review April 19, 2022 17:29
@BruceHaley BruceHaley requested a review from a team as a code owner April 19, 2022 17:29
@tracyboehrer tracyboehrer merged commit 7af7ef2 into main Apr 19, 2022
@tracyboehrer tracyboehrer deleted the bruce/fixcgalert4-18c branch April 19, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants